libxl: init_acpi_config should return rc in exit path, and set to 0 on success
authorWei Liu <wei.liu2@citrix.com>
Wed, 14 Dec 2016 11:44:36 +0000 (11:44 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Wed, 4 Jan 2017 17:00:36 +0000 (17:00 +0000)
commit443264ea123ca766a83a3cd37e25e23f171143f9
treeeaf3bdc19dac8f7cf4c367932d4c8a9f747f0b0b
parentd57590205ebab425d670340c788a9ad4f4ad9914
libxl: init_acpi_config should return rc in exit path, and set to 0 on success

init_acpi_config should return rc in exit path

... otherwise it returns 0 even if the function fails.

Coverity-ID: 1397121

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
(cherry picked from commit 1361db0ed3ad1217bd039a3cac5df49a622e12a9)

AND:

set rc to 0 in init_acpi_config in success path

xc_doamin_getinfo returns >=0 in success path, and if there is no vnode
configured, that rc will be returned to caller, which indicates error.

Fix that by setting rc to 0 in success path.

Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
(cherry picked from commit 08ccb46924385c833bd0da9e087fb6b96fa76849)

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_x86_acpi.c